-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ptt/init reporting #434
Ptt/init reporting #434
Conversation
include/comm_manager.h
Outdated
|
||
void send_parameter_list(); | ||
// void send_parameter_list(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to remove old code than comment it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/comm_manager.cpp
Outdated
@@ -129,7 +129,10 @@ void CommManager::param_request_list_callback(uint8_t target_system) | |||
if (target_system == sysid_) { send_params_index_ = 0; } | |||
} | |||
|
|||
void CommManager::send_parameter_list() { send_params_index_ = 0; } | |||
//void CommManager::send_parameter_list() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/comm_manager.cpp
Outdated
@@ -526,6 +534,23 @@ void CommManager::send_named_value_float(const char * const name, float value) | |||
|
|||
void CommManager::send_next_param(void) | |||
{ | |||
//PTT Hack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we figure out a more permanent solution for this before merging these changes into main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed hack, note initialization status will not be reported, that will require more code and maybe a request from rosflight io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we should think of a more permanent solution
Changes have been made to allow the board to send initialization status messages to the companion computer.
This requires also updating the board supports package in the varmint_h7 directory.